Adding all BDxxFC0 series LDO regulator #2853
Conversation
|
Violating S3.1
I've taken as an example other symbols. Violating S4.2
The power pins are often on the sides for regulators. |
diegoherranz
added
Pending reviewer
|
Hi @JonathSpirit , thankyou for your contribution. Footprint filters should be: And also a suggestion, i think it would be better for those symbols without enable, to totaly remove from decription, and leave it only to those symbols which applies. Not a full review, only a few quick comments.. |
|
Thanks for the review, I'm just confused for the TO263/TO252 filters. For example, TO-263-5_TabPin3 is not compatible with "WFP" symbols because pin 3 is not connected instead of GND so the filter should contain "TabPin6" ? And the filter should also logically contain the number of pins ? (TO-263-5) |
|
@JonathSpirit the fixes of @aris-kimi are correct. Fp filter are sometimes very permissive but it is normal + fp filter never contains the number of pins. One comment I have to do looking at the screenshots: the size of the outline is not usual for regulators. Height should be increased by 100mil. Joel PS @aris-kimi would you liek to continue the review here or not ? |
|
It looks like the width can be decreased as well. |
|
I resize all of the symbols by taking the existing regulators as an example (The only concern is that they are all different) and modify the footprint filters |
Regulator_Linear.lib
Outdated
| DEF BD00FC0WFP U 0 20 Y Y 1 F N | ||
| F0 "U" 0 300 50 H V C CNN | ||
| F1 "BD00FC0WFP" 0 200 50 H V C CNN | ||
| F2 "Package_TO_SOT_SMD:TO-263-5_TabPin6" 0 100 50 H I C CNN |
There was a problem hiding this comment.
package must be TO-252-5
There is no 263 at the ds. Please fix those parts that are wrong (if others) and adjust filters.
Adding all BDxxFC0 series LDO regulator
datasheet :
https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/linear_regulator/bdxxfc0wefj-e.pdf
Variable version (BD00FC0WFP, BD00FC0WEFJ) :
Fix without enable version (BDxxFC0FP) :
Alias :
Fix with enable version TO-263-5 (BDxxFC0WFP) :
Alias :
Fix with enable version HTSOP-8 (BDxxFC0WEFJ) :
Alias :
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.